{{ message }}
Implementing GetDynamicMemberNames() for PyObject#690
Merged
Conversation
filmor
requested changes
Jun 18, 2018
filmor
left a comment
filmor
left a comment
Member
There was a problem hiding this comment.
Fine for the most part, just check the two comments and add yourself to the contributors list (if you are not in there yet) and we can merge this. Thank you very much for this addition, good idea :)
| <PropertyGroup Condition=" '$(Configuration)' == 'DebugMono'"> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DefineConstants Condition="'$(DefineConstants)' == ''">DEBUG;TRACE</DefineConstants> | ||
| <DefineConstants Condition="'$(DefineConstants)' == ''">PYTHON2;PYTHON27;UCS4;TRACE;DEBUG</DefineConstants> |
Member
There was a problem hiding this comment.
These changes are not necessary, are they?
| #if PYTHON3 | ||
| "__ne__", | ||
| #endif | ||
| "__new__", |
Member
There was a problem hiding this comment.
The defines here make the whole thing quite brittle, I think, to me it would be perfectly fine to just check that the explicitly added members exist (i.e. add, getNumber etc.).
This reverts commit 56e5268.
Contributor
Author
|
Thanks for the feedback. I've addressed your comments. |
filmor
approved these changes
Jun 18, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This change implements GetDynamicMemberNames() for PyObject. This allows dynamic object members to be visible in the Visual Studio debugger.
Does this close any currently open issues?
#443
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG