Fix Console config, Add pyproj, Add PY3 to configurationmanager by vmuriart · Pull Request #346 · pythonnet/pythonnet · GitHub
Skip to content

Fix Console config, Add pyproj, Add PY3 to configurationmanager#346

Merged
vmuriart merged 6 commits into
pythonnet:masterfrom
vmuriart:project
Feb 2, 2017
Merged

Fix Console config, Add pyproj, Add PY3 to configurationmanager#346
vmuriart merged 6 commits into
pythonnet:masterfrom
vmuriart:project

Conversation

@vmuriart

@vmuriart vmuriart commented Jan 31, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Standardizes build configurations across the projects (Console.csproj had its own thing going on)
Adds @denfromufa 's *.pyproj with corrected configurations

@codecov-io

codecov-io commented Jan 31, 2017 •
edited
Loading

Copy link
Copy Markdown

@vmuriart vmuriart changed the title Fix MissingMinimumRules, Add pyproj Fix Console config, Add pyproj Jan 31, 2017
@vmuriart vmuriart changed the title Fix Console config, Add pyproj Fix Console config, Add pyproj, Add PY3 to configurationmanager Jan 31, 2017
@vmuriart vmuriart mentioned this pull request Jan 31, 2017
Merged
@vmuriart vmuriart force-pushed the project branch 2 times, most recently from 1234e3a to 8fe3f83 Compare January 31, 2017 22:19
filmor
filmor reviewed Feb 1, 2017
View reviewed changes
Comment thread .travis.yml

@filmor filmor Feb 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this still commented out?

@vmuriart vmuriart Feb 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs the tests but all say Cant find python.runtime error. Didn't have a chance to debug it. I'm keeping the tests paths updated though

@filmor filmor Feb 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fine by me then, but I'll open an issue for this, we should really start running those tests.

@vmuriart vmuriart Feb 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On appveyor, when we run them on py3 they freeze and hang the testrunner until the build bot times out (30 minutes or so?).
I stress tested it on PY27 and its def fixed there. Ran 10 times no issues.

@vmuriart vmuriart Feb 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filmor if we downgrade back to nunit 2.6.2 we can start running the tests. They will still fail, but nunit will gracefully fail and give us the error instead of whatever nunit3 is doing now

@vmuriart
Update test PyImport path
3f914ca 
Changed when consolidate output paths
@vmuriart vmuriart merged commit 9d317bf into pythonnet:master Feb 2, 2017
@vmuriart vmuriart deleted the project branch February 2, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor filmor approved these changes
@tonyroberts tonyroberts Awaiting requested review from tonyroberts
@den-run-ai den-run-ai Awaiting requested review from den-run-ai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmuriart @codecov-io @filmor