{{ message }}
Merged
Conversation
Member
filmor
commented
Sep 27, 2023
filmor
commented
- Add type offsets for 3.12 and update interop generation
- Drop unused custom incref/decref
- Add 3.12 to CI and metadata
filmor
force-pushed
the
python-3.12
branch
6 times, most recently
from
1c0a525 to
aa7426a
Compare
Member
Author
This was referenced Oct 3, 2023
raulcd
pushed a commit
to apache/arrow
that referenced
this pull request
Oct 3, 2023
### Rationale for this change The conda-integration build has recently started failing: https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453 Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249). ### What changes are included in this PR? Avoid using Python 3.12 for Archery in conda-integration build. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: #37993 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Member
|
Please take the commit from https://github.com/losttech/pythonnet/tree/instanceless-explicit to change the test. If it still does not raise in 3.12, keep the version guard and refer to python/cpython#101578 |
filmor
force-pushed
the
python-3.12
branch
2 times, most recently
from
53a8341 to
f988251
Compare
Member
Author
|
Same result. It actually does raise, but the reference check for |
Member
|
On Python 3.12 I think it should raise an instance of |
Member
Author
|
Well, that's not what this one is testing, though. I'll keep it deactivated for now. If the rest is fine with you, I'll merge it and cut a new version (maybe after having another look at #2245). |
Member
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change The conda-integration build has recently started failing: https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453 Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249). ### What changes are included in this PR? Avoid using Python 3.12 for Archery in conda-integration build. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#37993 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
4 tasks
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The conda-integration build has recently started failing: https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453 Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249). ### What changes are included in this PR? Avoid using Python 3.12 for Archery in conda-integration build. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#37993 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.