use enum name in repr by koubaa · Pull Request #2239 · pythonnet/pythonnet · GitHub
Skip to content

use enum name in repr#2239

Merged
lostmsu merged 8 commits intopythonnet:masterfrom
koubaa:pythonnet-enum-repr
Sep 22, 2023
Merged

use enum name in repr#2239
lostmsu merged 8 commits intopythonnet:masterfrom
koubaa:pythonnet-enum-repr

Conversation

@koubaa
Copy link
Copy Markdown
Contributor

@koubaa koubaa commented Sep 18, 2023 •
edited
Loading

What does this implement/fix? Explain your changes.

Proposal to fix #2238

Before the changes:

Python 3.11.4 (tags/v3.11.4:d2340ef, Jun  7 2023, 05:45:37) [MSC v.1934 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import clr; import System
>>> System.DayOfWeek.Monday
<System.DayOfWeek object at 0x0000024D5BAC7300>

IronPython (as a reference):

IronPython 2.7.4 (2.7.0.40) on .NET 4.0.30319.42000 (64-bit)
Type "help", "copyright", "credits" or "license" for more information.
>>> import System
>>> System.DayOfWeek.Monday
System.DayOfWeek.Monday

With these changes:

Python 3.11.4 (tags/v3.11.4:d2340ef, Jun  7 2023, 05:45:37) [MSC v.1934 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import clr; import System
>>> System.DayOfWeek.Monday
DayOfWeek.Monday

Checklist

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

This was referenced Sep 18, 2023
Merged
Closed
@lostmsu
Copy link
Copy Markdown
Member

lostmsu commented Sep 18, 2023 •
edited
Loading

@koubaa
Copy link
Copy Markdown
Contributor Author

koubaa commented Sep 19, 2023

@lostmsu Done - but I'm not really that happy with the Flags case. ToString() seems to make some choices about how to represent the value. Do you mean to only show the hex value if its Flags, instead of trying to show both integer and name?

@lostmsu
Copy link
Copy Markdown
Member

lostmsu commented Sep 19, 2023

@koubaa both of course.

lostmsu
lostmsu requested changes Sep 19, 2023
View reviewed changes
Comment thread src/runtime/Types/ClassObject.cs Outdated
Comment thread src/runtime/Types/ClassObject.cs Outdated
@koubaa
Copy link
Copy Markdown
Contributor Author

koubaa commented Sep 21, 2023

@lostmsu done.

The switch case isn't so pretty, but I couldn't think of a way to improve it. here's a minimal compiler explorer link with that logic if anyone wants to try and see if they can improve it: https://godbolt.org/z/dYG6sdnKo

@lostmsu
Copy link
Copy Markdown
Member

lostmsu commented Sep 21, 2023 •
edited
Loading

lostmsu
lostmsu reviewed Sep 21, 2023
View reviewed changes
Comment thread src/runtime/Types/ClassObject.cs Outdated
@lostmsu lostmsu merged commit 22d07dd into pythonnet:master Sep 22, 2023
koubaa added a commit to ansys/ansys-pythonnet that referenced this pull request Sep 25, 2023
@koubaa
Enum repr (#8)
5030f75 
mirror of upstream PR:
pythonnet/pythonnet#2239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lostmsu lostmsu lostmsu requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enum __repr__ string could be improved

2 participants

@koubaa @lostmsu