{{ message }}
Transfer the ownership of method's thunk to caller(split from #958)#1003
Merged
filmor merged 8 commits intopythonnet:masterfrom Dec 18, 2019
Merged
Transfer the ownership of method's thunk to caller(split from #958)#1003filmor merged 8 commits intopythonnet:masterfrom
filmor merged 8 commits intopythonnet:masterfrom
Conversation
Member
|
Is there a reason why we are not using |
Member
Author
|
Usually I also use |
Member
filmor
approved these changes
Dec 18, 2019
Member
filmor
left a comment
filmor
left a comment
There was a problem hiding this comment.
I think this can be simplified further in the future, but it's definitely better than it was before :)
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 27, 2020
…et#958) (pythonnet#1003) * Add exception helper * Make the caller of `Interop.GetThunk` handle thunk's lifecycle(unfinished) * Use Marshal.GetFunctionPointerForDelegate instead of Marshal + Thunk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Let the caller handle the lifecycle for achieving the memory release when shutdown pythonnet regardless of normal shutdown or soft shutdown in #958.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG