Fix refcnt errors (split from #958) by amos402 · Pull Request #1001 · pythonnet/pythonnet · GitHub
Skip to content

Fix refcnt errors (split from #958)#1001

Merged
filmor merged 4 commits intopythonnet:masterfrom
amos402:fix-refcnt-errors
Dec 2, 2019
Merged

Fix refcnt errors (split from #958)#1001
filmor merged 4 commits intopythonnet:masterfrom
amos402:fix-refcnt-errors

Conversation

@amos402
Copy link
Copy Markdown
Member

@amos402 amos402 commented Nov 30, 2019

What does this implement/fix? Explain your changes.

Still has many refcnt error inside, since I use some new mechanisms for fixing other errors, if I fix them directly some tests may crash. So here just few fixes about the refcnt errors.

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 30, 2019

@filmor filmor merged commit 5f56ebc into pythonnet:master Dec 2, 2019
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 27, 2020
* Add exception helper
* Fixed refcnt error in ExtensionType.FinalizeObject
* Fixed typename leaking
* Fix refcnt error by using `using`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants