{{ message }}
Repository navigation
fix: build only the sdist in the release job - #1921
Merged
Merged
Conversation
bdraco
marked this pull request as ready for review
September 28, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release job built a wheel next to the sdist, and that wheel is now tagged
linux_x86_64, which PyPI rejects, so 0.151.4 was tagged but never uploaded. The release job now builds the sdist only, all wheels come from the cibuildwheel jobs that run after it.Test plan
Ran
poetry build --format sdistlocally, it produces onlyzeroconf-0.151.4.tar.gzwithbuild_ext.pyand the.pxdfiles included.