{{ message }}
Repository navigation
test: widen loopback find timeout on macos - #1832
Merged
Merged
Conversation
bdraco
marked this pull request as ready for review
August 28, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_integration_with_subtype_and_listenerfailed twice recently, both times on macos runners (3.10 and 3.13), with the secondfind()returning(); the captured log shows the registrar's PTR response was sent and received, it just landed after the 75msfind()sleep had already cancelled the browser.Details
find()is a fixedtime.sleep(timeout), so the timeout is a hard budget for the whole query and response round trip; locally that round trip is 1 to 7ms for every test in the file, on GitHub's macos runners the process stalls for longer than 75ms often enough to lose the answerLOOPBACK_FIND_TIMEOUTPyPy already uses, other platforms keep 75ms; this adds about 1.8s to each macos jobTest plan
tests/services/test_types.pypasses locally on macos with the new budgetadd_servicelatency for bothfind()phases of the plain and subtype tests, 1 to 7ms in every run, so the failures are runner stalls rather than a systematic slow path