Use pytest-mpl to check the images by ocefpaf · Pull Request #197 · python-windrose/windrose · GitHub
Skip to content

Use pytest-mpl to check the images#197

Merged
ocefpaf merged 9 commits into
python-windrose:mainfrom
ocefpaf:pytest-mpl
Sep 20, 2022
Merged

Use pytest-mpl to check the images#197
ocefpaf merged 9 commits into
python-windrose:mainfrom
ocefpaf:pytest-mpl

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Sep 19, 2022

Copy link
Copy Markdown
Collaborator

@scls19fr this is a major refactor on the test and I hope it is OK. We need to catch issues like #190.

@ocefpaf

ocefpaf commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator Author

@ocefpaf ocefpaf requested a review from s-celles September 20, 2022 16:30
@ocefpaf

ocefpaf commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator Author

This one is ready for review. When merged I'll unpin rebase #191 and unpin matplotlib to ensure we catch all the differences in the new version.

@s-celles

Copy link
Copy Markdown
Member

I just hope this kind of tests won't break too often.
Let's give it a try.

@s-celles

Copy link
Copy Markdown
Member

Lgtm

@ocefpaf

ocefpaf commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator Author

@ocefpaf ocefpaf merged commit 80de000 into python-windrose:main Sep 20, 2022
@ocefpaf ocefpaf deleted the pytest-mpl branch September 20, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants