{{ message }}
Fix docs gha#177
Merged
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
Docs are build and the failed linkcheck is expected b/c the file will be on that URL after the merge of this PR. See https://github.com/python-windrose/windrose/runs/6324143101?check_suite_focus=true#step:6:91 |
ocefpaf
commented
May 6, 2022
| push: | ||
| branches: | ||
| - [master, main] | ||
| branches: [master, main] |
Collaborator
Author
There was a problem hiding this comment.
@scls19fr this should fix the error that is happening on master.
Collaborator
Author
There was a problem hiding this comment.
This PR changes how we this part of the documentation. Instead of a rst file we have a notebook that is run at build time, to ensure it is working. That reduces the number of files we need to sync (screenshots, instructions in multiple places, etc) and make it easier for users b/c they can download the notebook and run the docs if they want to follow along.
… up when changes happen
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, testing with nbsphix, not ready for review yet.