Auto-publish on PyPI and test test the tarball by ocefpaf · Pull Request #174 · python-windrose/windrose · GitHub
Skip to content

Auto-publish on PyPI and test test the tarball#174

Merged
s-celles merged 1 commit into
python-windrose:masterfrom
ocefpaf:PyPI
May 5, 2022
Merged

Auto-publish on PyPI and test test the tarball#174
s-celles merged 1 commit into
python-windrose:masterfrom
ocefpaf:PyPI

Conversation

@ocefpaf

@ocefpaf ocefpaf commented May 4, 2022

Copy link
Copy Markdown
Collaborator

Not ready for review yet. Only merge after #173

Closes #110

@s-celles

s-celles commented May 4, 2022

Copy link
Copy Markdown
Member

@ocefpaf

ocefpaf commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

Pypi invite sent https://pypi.org/manage/project/windrose/collaboration/

Accepted and added the upload token to the secrets here. The sdist and wheel tests are passing but an upload to PyPI only happen if we have a tag. See https://github.com/python-windrose/windrose/runs/6292093461?check_suite_focus=true

I'll try to get to a new release that has the fix for #170 later today.

@ocefpaf ocefpaf marked this pull request as ready for review May 4, 2022 15:10
@s-celles

s-celles commented May 4, 2022

Copy link
Copy Markdown
Member

You probably should enable 2FA on your Pypi account.
I personnally use Authy https://authy.com/ but hardware key seems to also be supported (ie Yubikey or any other U2F/FIDO2 keys)

@ocefpaf

ocefpaf commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

You probably should enable 2FA on your Pypi account.

I had it enabled and was bitten really badly by it: pypi/support#1201

I believe they have better recovery mechanisms so and I should try to re-enable it.

@s-celles

s-celles commented May 4, 2022

Copy link
Copy Markdown
Member

you need to store you recovery keys and Pypi ask for one key before adding your 2FA application code (to ensure that you keep recovery keys somewhere)

@ocefpaf

ocefpaf commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

you need to store you recovery keys and Pypi ask for one key before adding your 2FA application code (to ensure that you keep recovery keys somewhere)

Yeah. I had a bad luck of having my phone, with the Google Authenticator, my laptop, and my physical notebook with the recovery keys stolen with my backpack. Should probably not carry all together in a single place :-)

However, most 2FAs I had allowed me to recover by other means in a matter of minutes, not PyPI. It took them months to process my request. Anyway, I'm enabling it again.

@s-celles

s-celles commented May 4, 2022

Copy link
Copy Markdown
Member

That's why I prefer Authy over Google Auth... Because of Sync accross several devices

@ocefpaf

ocefpaf commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

@s-celles s-celles merged commit 494ee41 into python-windrose:master May 5, 2022
@ocefpaf ocefpaf deleted the PyPI branch May 5, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pypi deployment using Travis CI

2 participants