Fix default behavior of WindroseAxes.from_ax(). by 15b3 · Pull Request #166 · python-windrose/windrose · GitHub
Skip to content

Fix default behavior of WindroseAxes.from_ax().#166

Merged
s-celles merged 1 commit into
python-windrose:masterfrom
15b3:fix_from_ax_default
Oct 26, 2021
Merged

Fix default behavior of WindroseAxes.from_ax().#166
s-celles merged 1 commit into
python-windrose:masterfrom
15b3:fix_from_ax_default

Conversation

@15b3

@15b3 15b3 commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

Fix #165.

First, returns None if it does not have a key or if None is set.
Then, if None, then assign ["E", ...].

self.theta_labels = kwargs.pop("theta_labels", None)
if self.theta_labels is None:
    self.theta_labels = ["E", "N-E", "N", "N-W", "W", "S-W", "S", "S-E"])

@15b3 15b3 changed the title Fix default behavior of WindroseAxis.from_ax(). Fix default behavior of WindroseAxes.from_ax(). Oct 26, 2021
@s-celles s-celles merged commit 6b33300 into python-windrose:master Oct 26, 2021
@s-celles

s-celles commented Oct 26, 2021

Copy link
Copy Markdown
Member

@ocefpaf

ocefpaf commented May 4, 2022

Copy link
Copy Markdown
Collaborator

@ocefpaf ocefpaf mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default behavior of theta_labels in WindroseAxes.from_ax() is not user-friendly.

3 participants

@15b3 @s-celles @ocefpaf