Fix clean method in case var is nan. by 15b3 · Pull Request #164 · python-windrose/windrose · GitHub
Skip to content

Fix clean method in case var is nan. #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-celles merged 1 commit into from
Oct 25, 2021
Merged

Fix clean method in case var is nan. #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
34 changes: 34 additions & 0 deletions tests/test_windrose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@
# from windrose import FIGSIZE_DEFAULT, DPI_DEFAULT
from windrose import wrbar, wrbox, wrcontour, wrcontourf, wrpdf, wrscatter
from windrose import plot_windrose
from windrose import clean, clean_df

import numpy as np
import pandas as pd
from numpy.testing import assert_allclose
from pandas.testing import assert_frame_equal


# Create wind speed and direction variables
Expand Down Expand Up @@ -208,3 +211,34 @@ def test_windrose_pd_not_default_names():
# #df = df.reset_index()
# #df = df.set_index([by, 'Timestamp'])
# #print(df)


def test_windrose_clean():
direction = np.array(
[1.0, 1.0, 1.0, np.nan, np.nan, np.nan]
)
var = np.array(
[2.0, 0.0, np.nan, 2.0, 0.0, np.nan]
)
actual_direction, actual_var = clean(direction, var)
expected_direction = np.array([1.0])
expected_var = np.array([2.0])
assert_allclose(actual_direction, expected_direction)
assert_allclose(actual_var, expected_var)


def test_windrose_clean_df():
df = pd.DataFrame(
{
"direction": [1.0, 1.0, 1.0, np.nan, np.nan, np.nan],
"speed": [2.0, 0.0, np.nan, 2.0, 0.0, np.nan],
}
)
actual_df = clean_df(df)
expected_df = pd.DataFrame(
{
"direction": [1.0],
"speed": [2.0],
}
)
assert_frame_equal(actual_df, expected_df)
6 changes: 3 additions & 3 deletions windrose/windrose.py
View file
Open in desktop