{{ message }}
Fix: Allow Special DOI Cases Used in Public Administration Tests#415
Merged
Conversation
Collaborator
Contributor
Author
|
Hi! According to the official government website where the control digit calculation is explained, there is no mention of any specific DOIs being considered invalid. Moreover, the DOIs that were previously excluded are validated correctly in the most commonly used public tools: Therefore, it seems clear that these codes should not be excluded in the validation. Thank you for reviewing! |
nandgator
requested changes
Mar 29, 2025
| ("12345",), | ||
| ("X0000000T",), | ||
| ("00000000T",), | ||
| ("00000001R",), |
Collaborator
There was a problem hiding this comment.
If these are valid, can you please put them in the valid nif test cases?
nandgator
added
Breaking Changes
nandgator
approved these changes
Apr 26, 2025
The special cases excluded from the validation represent valid codes, used in test environments.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation previously excluded certain DOI codes that are actually valid and commonly used in test environments by public administration entities. These codes, although not assigned to real individuals, should be considered valid for all practical purposes.
This change ensures that the validation logic aligns with real-world usage, preventing false negatives when handling official test scenarios.
Let me know if any adjustments are needed! 🚀