{{ message }}
Sometimes notify_closing can be called on dead events - #3503
Merged
Merged
Conversation
A5rocks
force-pushed
the
notify-closing-race
branch
from
September 5, 2026 00:38
8e2fc98 to
d887165
Compare
A5rocks
force-pushed
the
notify-closing-race
branch
from
September 5, 2026 05:55
d887165 to
b97da89
Compare
A5rocks
force-pushed
the
notify-closing-race
branch
from
September 9, 2026 00:42
5387ebb to
7169163
Compare
Contributor
Author
|
I'll close this in favor of the more general solution @arthur-tacca was proposing. |
Contributor
Author
|
Gah, I forgot what this PR did. NVM! |
CoolCat467
approved these changes
Sep 17, 2026
CoolCat467
left a comment
Member
There was a problem hiding this comment.
From what I understand this is probably fine.
Contributor
|
Sorry I just noticed that this only checks for except OSError as e:
if e.errno == errno.ENOENT: # pragma: no branch
# the event isn't in kqueue
continueBut for similar code in |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #3502 since this is the repro they were describing, I think.