Improved comments for clarity and details :)#4565
Improved comments for clarity and details :)#4565Bibo-Joshi merged 4 commits intodoc-fixesfrom unknown repository
Conversation
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hi. Thanks very much for your PR! AFAIK you've already discussed the changes with Poolitzer. I've added a few additional comments below. None of them are critical.
Please also have a look at the failing pre-commit checks. They are due to a few lines exceeding the line length limit of 99 chars.
There was a problem hiding this comment.
this comment is used in all examples. If it's changed, I would like to have it adapted in the other examples as well
There was a problem hiding this comment.
I'm unsure whether I should revert it or apply the same change to all the other examples.
There was a problem hiding this comment.
Your call :) I'm fine with either solution. Thanks for the other updates!
There was a problem hiding this comment.
Well, I've changed it back to the original because I believe both versions explain the purpose well.
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the update! Now only the pre-commit failure is remaining:)
|
Passed ;) |
2 participants
Improved comments for clarity and details in payment bot example: