{{ message }}
Reduce Creation of HTTP Clients in Tests#4493
Merged
Bibo-Joshi merged 5 commits intomasterfrom Sep 25, 2024
Merged
Conversation
harshil21
reviewed
Sep 21, 2024
Member
harshil21
left a comment
harshil21
left a comment
There was a problem hiding this comment.
Do you know what % of time was the calling of load_ssl_context_verify taking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the function
load_ssl_context_verifythat's called upon the creation ofhttpx.AsyncClienttakes quite a bit of time so that creating newHTTPXRequestobjects (indirectly viaBot) is a performance bottleneck in the tests.Hence, this changing
make_botto useoffline=Trueby default and allowing online only in the tests that make requests.This is just one small step on test performance improvement, but hey it's something :)