{{ message }}
Add walrus operator wherever possible - #3749
Merged
Bibo-Joshi merged 3 commits intoJun 8, 2023
Merged
Bibo-Joshi merged 3 commits into
Bibo-Joshi merged 3 commits into
Conversation
Contributor
Author
Member
|
Thanks for the PR! The tests are failing on some other PRs since yesterday, too. Seems like something changed in the TG servers. We'll have to investigate. |
Bibo-Joshi
reviewed
Jun 7, 2023
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
Member
There was a problem hiding this comment.
The failing tests seem to have recovered. Now only TestInlineQueryHandler.test_context_pattern is failing. I guess that's due to your changes though TBH I don't really see a flaw in those … Would you mind double check ing that?
Contributor
Author
|
@Bibo-Joshi should be fixed now :) Edit: oof the tests still fail but this is related to submitting the test coverage, all the tests pass. so not the code. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #3734
I have tried to add the walrus operator wherever possible.
I went through most files.
There were a couple more instances I found where I could have added it, but it was unnecessary and would not have necessarily improved readability or code quality.
I was more lenient when it came to adding the walrus operator to tests