{{ message }}
Repository navigation
Keep the first of duplicate TIFF tags - #10210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #10201
Pillow/Tests/test_file_libtiff.py
Lines 1343 to 1345 in bc7e6f5
If libtiff keeps the first of duplicate tags, then let's do the same.
Pillow/Tests/test_file_libtiff.py
Lines 1329 to 1331 in bc7e6f5
If libtiff is ignoring a malformed PhotometricInterpretation tag, then let's do the same.
With these changes, the test no longer fails the C checks from the earlier PR.
The C code can be left in as a defensive measure for when Pillow and libtiff disagree, but this PR stops them from disagreeing in the first place.