Fix from_format using local timezone even when timezone is provided. by ayoung19 · Pull Request #616 · python-pendulum/pendulum · GitHub
Skip to content

Fix from_format using local timezone even when timezone is provided.#616

Open
ayoung19 wants to merge 1 commit intopython-pendulum:masterfrom
ayoung19:master
Open

Fix from_format using local timezone even when timezone is provided.#616
ayoung19 wants to merge 1 commit intopython-pendulum:masterfrom
ayoung19:master

Conversation

@ayoung19
Copy link
Copy Markdown

@ayoung19 ayoung19 commented Apr 16, 2022

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Fixes #613

@ayoung19
Copy link
Copy Markdown
Author

Copy link
Copy Markdown

@jamwine jamwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timezone within the now() will create a DateTime instance in accordance with the proper timezone.

@ayoung19
Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

breaking: from_format errors out when there is no local timezone configuration but timezone is passed in

2 participants