{{ message }}
Support workspace symbols#511
Open
eyalk11 wants to merge 2 commits into
Open
Conversation
Author
Member
|
Hey @eyalk11, thanks for your contribution! I think Jedi provides a better way to extract workspace symbols than doing it file by file, which seems inefficient. Besides that, your work is also missing tests. |
Author
|
What is the better method? I mean I suppose it doesn't parse all the files by default. |
|
i'd like to help with this, but i'm reading jedi docs and i can't find any included method to extract workspace symbols, only getting names from a singular script. @ccordoba12 could you clarify what exactly you meant here? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It simply works. (
Telescope lsp_workspace_symbols)The only comment is that the formatting of document.path and d.module_path was different (don't know why the hell) -
(C:\... vs uri or \...) , so I used the full path for telescope to handle this.