{{ message }}
Replace asyncio.wait_for with async-timeout - #480
Merged
Merged
Conversation
bdraco
marked this pull request as ready for review
July 21, 2023 02:43
rytilahti
reviewed
Jul 21, 2023
bdraco
commented
Jul 21, 2023
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
rytilahti
changed the title
Member
|
How crucial it is to get this released rather sooner than later? Currently a bit busy with other things, so if a new release can wait I'd rather do it later. |
Member
Author
|
It's hard to tell from the information users have provided if they have network problems or are getting hitting by races with wait_for which makes it difficult to give a good answer here. I suspect we have both cases. It would be great to have it released in time for beta on Wednesday. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: CI failure is fixed by #482
asyncio.wait_forhas some underlying problems that are only fixed in cpython 3.12.Use
async_timeoutinstead until the minimum supported version is 3.11+ and it can be replaced withasyncio.timeoutSee python/cpython#98518