Preserve explicit Connection header casing by Mirochill · Pull Request #195 · python-hyper/h11 · GitHub
Skip to content

Preserve explicit Connection header casing #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mirochill wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −3
Open

Preserve explicit Connection header casing #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions h11/_connection.py
View file
Open in desktop
17 changes: 17 additions & 0 deletions h11/tests/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,23 @@ def test_automagic_connection_close_handling() -> None:
assert conn.states == {CLIENT: MUST_CLOSE, SERVER: MUST_CLOSE}


def test_explicit_connection_close_preserves_header_case() -> None:
c = Connection(SERVER)
c.receive_data(
b"GET / HTTP/1.1\r\n"
b"Host: example.com\r\n"
b"Connection: close\r\n"
b"\r\n"
)
assert isinstance(c.next_event(), Request)
assert isinstance(c.next_event(), EndOfMessage)

assert (
c.send(Response(status_code=204, headers=[("connection", "close")]))
== b"HTTP/1.1 204 \r\nconnection: close\r\n\r\n"
)


def test_100_continue() -> None:
def setup() -> ConnectionPair:
p = ConnectionPair()
Expand Down
2 changes: 2 additions & 0 deletions newsfragments/156.bugfix.rst
View file
Open in desktop