Unconditionally consume buffers to avoid stale data by ngoldbaum · Pull Request #226 · python-hyper/brotlicffi · GitHub
Skip to content

Unconditionally consume buffers to avoid stale data #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmlarson merged 2 commits into from
Aug 20, 2026
Merged

Unconditionally consume buffers to avoid stale data #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d36f46b
Unconditionally consume buffers to avoid stale data
ngoldbaum Aug 20, 2026
1b0be25
Drop Python 3.8 builds
ngoldbaum Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
6 changes: 2 additions & 4 deletions src/brotlicffi/_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,10 +497,8 @@ def _decompress(self, data, output_buffer_limit):
chunks.append(chunk)
chunks_len += len(chunk)

# Save any unconsumed input for the next call.
if available_in[0] > 0:
remaining_input = ffi.buffer(next_in[0], available_in[0])[:]
self._unconsumed_data = remaining_input
# Save input for the next call
self._unconsumed_data = ffi.buffer(next_in[0], available_in[0])[:]

# Check if we've reached the output limit.
if (
Expand Down
19 changes: 19 additions & 0 deletions test/test_simple_decompression.py
View file
Open in desktop
Loading