{{ message }}
Conversation
Add a copy of the pythoncapi_compat.h header: https://github.com/pythoncapi/pythoncapi_compat pythoncapi_compat.h provides PyThreadState_EnterTracing() and PyThreadState_LeaveTracing() to Python 3.10 and older. They function were added to Python 3.11.0a2: python/cpython@547d26a PyThreadState.cframe.use_tracing format changed again in Python 3.11.0a2 (value set to 0 or 255): python/cpython@bd627eb This change makes greenlet ready for these changes and future CPython internal changes.
Contributor
Author
Contributor
|
Thanks for the heads up! Rather than vendor an entire header file, I'll probably just add only the definitions greenlet needs to the existing header as it needs them. |
Contributor
Author
|
Oh, pythoncapi_compat.h would also allow to remove another compatibility function: |
Contributor
Author
My long term plan is to ship pythoncapi_compat.h as part of Python itself and/or install it on the system, as the six module is now preinstalled or easy to install on any system. For now, I prefer to copy it in each project. |
Contributor
Author
|
If you don't want to use pythoncapi_compat.h for now, here is a different PR without it: #268 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add a copy of the pythoncapi_compat.h header:
https://github.com/pythoncapi/pythoncapi_compat
pythoncapi_compat.h provides PyThreadState_EnterTracing() and
PyThreadState_LeaveTracing() to Python 3.10 and older. They function
were added to Python 3.11.0a2:
python/cpython@547d26a
PyThreadState.cframe.use_tracing format changed again in Python
3.11.0a2 (value set to 0 or 255):
python/cpython@bd627eb
This change makes greenlet ready for these changes and future CPython
internal changes.