Add logo and benchmarks to README#60
Conversation
SultanOrazbayev
left a comment
SultanOrazbayev
left a comment
There was a problem hiding this comment.
This one also looks great, Erik! :)
There was a problem hiding this comment.
It's a small thing, but the last letter in "graphblas" is a bit cropped out. I think it still works, though, so not a serious issue.
There was a problem hiding this comment.
Really? I don't think I see that. Can you take a screenshot of what you are seeing?
There was a problem hiding this comment.
I checked Chrome and Safari, both look like this for me...
There was a problem hiding this comment.
And now that I'm looking at it again, the last s in algorithms is also gone... Interesting.
There was a problem hiding this comment.
I tried playing around with zoom to see if that would make a diff, but nope.
There was a problem hiding this comment.
I see this now (on my macbook); it renders fine for me on Windows where I created it. Thanks for letting me know!
There was a problem hiding this comment.
Okay, I think the logo should be fixed now if you'd like to take a look to verify.
There was a problem hiding this comment.
To recap testing on my end: looks good on MacOS and Windows, looks truncated on Ubuntu.
|
nope looks the same
…On Sat, 22 Apr 2023 at 03:39, Erik Welch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On docs/_static/img/logo-name-medium.svg
<#60 (comment)>
:
Okay, I think the logo should be fixed now if you'd like to take a look to
verify.
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2FWESMMOA7WNUKCUXOEUTXCL5A3ANCNFSM6AAAAAAW7UPWYM>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
Dope! Thanks for checking. Jim and I have learned that the font looks very different on different systems (Windows, Mac, Android, etc). So, I think @jim22k is going to convert all the svg logos to PNGs (Jim, don't forget to minimize the PNGs--such as from https://compresspng.com/ and https://tinypng.com/ --to improve page load times!). |
|
I switched from svg to png. This bumps the logo size from 1k to 35k, but I think it's worth it to avoid the need to grab fonts from the local machine, which leads to different looks and widths. PNG will always be consistent. |
SultanOrazbayev
left a comment
SultanOrazbayev
left a comment
There was a problem hiding this comment.
Looks good! Interesting the file size is so large (35K), but small enough to not be an issue.
4 participants
This is a companion PR to python-graphblas/python-graphblas#432
I copied the logo from that PR and manually modified it.