iframe-proxy

JohnVillalovos · 2025-10-18T17:41:25Z

When an epic belonging to a subgroup is retrieved through a parent
group's epic listing, save() and delete() operations would fail because
they used the parent group's path instead of the epic's actual group_id.

Add an internal custom path hook for object save and delete operations, and let
UpdateMixin and DeleteMixin accept an explicit _custom_path keyword. GroupEpic
uses this hook to build mutation paths from the epic's server-provided group_id,
so save() and delete() target the epic's owning group.

Avoid using parent manager attrs as a fallback for the epic group path. Lazy
epics do not have a server-provided group_id, so raise a clear error instead of
silently using the parent group path.

Add unit coverage for custom update/delete paths, GroupEpic save/delete path
selection, and lazy epic path failures. Add a functional test for saving a
subgroup epic discovered through the parent group listing.

Assisted-by: OpenAI Codex (GPT-5)

Closes: #3261

Copilot

Pull Request Overview

This PR fixes an issue where save() and delete() operations on epics retrieved through a parent group's epic listing would fail because they used the wrong group path. The fix ensures that operations use the epic's actual group_id attribute to construct the correct API path.

Overrides save() and delete() methods in GroupEpic to use the epic's group_id for API path construction
Adds helper method _epic_path() to compute the correct API path using the epic's real group
Adds comprehensive test coverage for both unit and functional scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-10-22T00:01:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.77%. Comparing base (659c648) to head (e3d27cc).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
+ Coverage   92.16%   95.77%   +3.61%     
==========================================
  Files         100      100              
  Lines        6125     6153      +28     
==========================================
+ Hits         5645     5893     +248     
+ Misses        480      260     -220

Flag	Coverage Δ
api_func_v4	`83.76% <90.90%> (?)`
cli_func_v4	`78.46% <60.60%> (-0.12%)`	⬇️
unit	`90.28% <100.00%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
gitlab/mixins.py	`91.86% <100.00%> (+5.56%)`	⬆️
gitlab/v4/objects/epics.py	`91.22% <100.00%> (+13.45%)`	⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

JohnVillalovos · 2025-12-06T18:12:16Z

nejch

Thanks @JohnVillalovos, looks good and that's a tricky one. Not sure about lazily fetched epics - just have a few questions there.

…epics When an epic belonging to a subgroup is retrieved through a parent group's epic listing, save() and delete() operations would fail because they used the parent group's path instead of the epic's actual group_id. Add an internal custom path hook for object save and delete operations, and let UpdateMixin and DeleteMixin accept an explicit `_custom_path` keyword. GroupEpic uses this hook to build mutation paths from the epic's server-provided group_id, so save() and delete() target the epic's owning group. Avoid using parent manager attrs as a fallback for the epic group path. Lazy epics do not have a server-provided group_id, so raise a clear error instead of silently using the parent group path. Add unit coverage for custom update/delete paths, GroupEpic save/delete path selection, and lazy epic path failures. Add a functional test for saving a subgroup epic discovered through the parent group listing. Assisted-by: OpenAI Codex (GPT-5) Closes: #3261

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 18, 2025 17:41

JohnVillalovos marked this pull request as draft October 18, 2025 17:41

Copilot AI reviewed Oct 18, 2025

View reviewed changes

Comment thread gitlab/v4/objects/epics.py Outdated

Comment thread gitlab/v4/objects/epics.py Outdated

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 0f7065d to 3e75d60 Compare October 21, 2025 22:59

JohnVillalovos requested a review from Copilot October 21, 2025 23:02

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Comment thread gitlab/mixins.py Outdated

Comment thread gitlab/v4/objects/epics.py Outdated

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 3e75d60 to 3993fe7 Compare October 21, 2025 23:05

JohnVillalovos requested a review from Copilot October 21, 2025 23:06

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Comment thread gitlab/v4/objects/epics.py Outdated

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch 2 times, most recently from 3e855f3 to 27bd80c Compare October 21, 2025 23:33

JohnVillalovos requested a review from Copilot October 21, 2025 23:35

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Comment thread gitlab/v4/objects/epics.py

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 27bd80c to dcc9847 Compare October 21, 2025 23:42

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from dcc9847 to f420862 Compare October 22, 2025 00:25

JohnVillalovos requested a review from Copilot October 22, 2025 00:26

Copilot AI reviewed Oct 22, 2025

View reviewed changes

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from f420862 to a9638ee Compare October 22, 2025 00:42

JohnVillalovos mentioned this pull request Oct 22, 2025

GroupEpic uses "iid" as ID attribute but should use "id"? #3261

Open

JohnVillalovos marked this pull request as ready for review November 10, 2025 16:02

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from a9638ee to fb4f902 Compare November 10, 2025 16:02

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from fb4f902 to 8397bd0 Compare December 6, 2025 18:11

JohnVillalovos requested a review from nejch December 6, 2025 18:12

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 8397bd0 to 45a8599 Compare December 11, 2025 00:56

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 45a8599 to 0dd6ab1 Compare December 24, 2025 21:42

nejch reviewed Dec 24, 2025

View reviewed changes

Comment thread gitlab/v4/objects/epics.py Outdated

Comment thread gitlab/v4/objects/epics.py Outdated

Comment thread gitlab/mixins.py Outdated

Comment thread tests/functional/api/test_epics.py

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 0dd6ab1 to ce876ef Compare December 25, 2025 14:34

nejch assigned JohnVillalovos Dec 30, 2025

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from ce876ef to 0f029e9 Compare January 19, 2026 23:14

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch 4 times, most recently from 83feda8 to cfe29a4 Compare April 18, 2026 18:04

JohnVillalovos marked this pull request as draft April 18, 2026 18:25

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch 2 times, most recently from f187c43 to 4702278 Compare April 18, 2026 19:42

JohnVillalovos force-pushed the jlvillal/3261_epic_group branch from 4702278 to e3d27cc Compare April 18, 2026 19:55

JohnVillalovos requested a review from Copilot April 18, 2026 19:56

Copilot started reviewing on behalf of JohnVillalovos April 18, 2026 19:57 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread gitlab/v4/objects/epics.py

JohnVillalovos marked this pull request as ready for review April 18, 2026 20:27

JohnVillalovos requested a review from nejch April 18, 2026 20:27

File	Description
gitlab/v4/objects/epics.py	Implements the fix by overriding save() and delete() methods to use epic's group_id for path construction
tests/unit/objects/test_epics.py	Adds unit tests to verify save() and delete() operations use the correct group path
tests/functional/api/test_epics.py	Adds functional test demonstrating the fix works for nested epics accessed through parent groups

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

JohnVillalovos commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

codecov Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

JohnVillalovos commented Dec 6, 2025

Uh oh!

nejch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JohnVillalovos commented Oct 18, 2025 •

edited

Loading

codecov Bot commented Oct 22, 2025 •

edited

Loading