{{ message }}
Add some miscellaneous tests - #659
Merged
Merged
Conversation
brianschubert
commented
Aug 25, 2025
AlexWaygood
reviewed
Aug 25, 2025
The Python 3.10+ implementation started raising in PR#165
Contributor
Author
Daraan
reviewed
Aug 30, 2025
Daraan
left a comment
Daraan
left a comment
Contributor
There was a problem hiding this comment.
making ParamSpec.init_subclass raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in #165, which didn't include a changelog entry.
Imo, it's worth noting. That it is now consistent with the other versions.
Member
AlexWaygood
reviewed
Aug 30, 2025
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Daraan <github.blurry@9ox.net>
AlexWaygood
approved these changes
Aug 30, 2025
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Looks great! I think there's a merge conflict
AlexWaygood
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests to exercise some previously unexercised lines:
_SpecialGenericAlias.__setattr__()for non-dunder, non-"allowed" attributes (src)_SpecialGenericAliasfrom without defaults (src)_SpecialGenericAliaswith 0 type parameters (src)<thing>.__module__on Python implementations that don't supplysys._getframemodulenameorsys._getframe(src)get_type_hints()withtypes.GenericAlias(src)__init_subclass__()ofParamSpec(src)__or__()and__ror__()of_SpecialForm(src)__repr__and__reduce__ofNoExtraItems(test case copied fromNoDefaultTests) (src)