{{ message }}
Backport get_origin() and get_args() - #698
Merged
Merged
Conversation
The implementations come from CPython commit 427c84f13f77 with one small change – the get_origin's docstring mentions Annotated as it's also supported. get_origin() and get_args() introduced in [1] and modified in [2] to support Annotated. [1] python/cpython#13685 [2] python/cpython#18260
… 3.8 Otherwise typing_extensions.get_origin() would not recognize typing_extensions.Annotated on 3.8.
Contributor
Author
Member
|
Yeah, it looks like it belongs in the exclude list (maybe only in 3.8.x?) |
gvanrossum
reviewed
Feb 7, 2020
Member
There was a problem hiding this comment.
sys.version_info[:2] >= (3, 9)
gvanrossum
approved these changes
Feb 7, 2020
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LGTM. I'd wait a few days for @ilevkivskyi -- Ivan, if you're okay with my review just say so and I'll merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementations come from CPython commit 427c84f13f77 with one small
change – the get_origin's docstring mentions Annotated as it's also
supported.
get_origin() and get_args() introduced in [1] and modified in [2] to
support Annotated.
[1] python/cpython#13685
[2] python/cpython#18260