{{ message }}
Clarify generic type parameter ordering - #2289
Open
BHUVANSH855 wants to merge 4 commits into
Open
BHUVANSH855 wants to merge 4 commits into
BHUVANSH855 wants to merge 4 commits into
Conversation
Member
JelleZijlstra
requested changes
May 21, 2026
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
I think we should add a section header "Type parameter ordering", starting at line 487 or so. Currently this is in a section "Arbitrary generic types as base classes", which isn't really apposite.
Member
|
Also, is this already covered sufficiently in the conformance suite? What are the relevant tests that we have? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify how type parameter ordering is determined for generic classes.
This expands the existing wording in the generics spec to explicitly
cover:
Generic[...]base classesProtocol[...]base classesThe updated wording also clarifies that a bare
Protocolbase classdoes not affect type parameter ordering.
Closes #2059