[socket] Use concrete classes for socket.makefile return types by srittau · Pull Request #16587 · python/typeshed · GitHub
Skip to content

[socket] Use concrete classes for socket.makefile return types - #16587

Open
srittau wants to merge 3 commits into
python:mainfrom
srittau:socket-makefile
Open

srittau wants to merge 3 commits into
python:mainfrom
srittau:socket-makefile

Conversation

@srittau

@srittau srittau commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

This is the only function that returns IOBase, which does not have standard read and write methods. Check whether this overload is actually needed.

Cf. #16583

@srittau srittau changed the title Remove socket.makefile fallback overload [socket] Remove socket.makefile fallback overload Oct 21, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

@srittau srittau changed the title [socket] Remove socket.makefile fallback overload [socket] Use concrete classes for socket.makefile return types Oct 21, 2026
@srittau

srittau commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@srittau
srittau marked this pull request as ready for review October 21, 2026 10:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant