{{ message }}
Fix rasterio rowcol operation return type - #16352
Open
ryux1 wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Member
There was a problem hiding this comment.
Astra thinks this is wrong:
index() must not propagate the callback’s return type. Its implementation explicitly returns
tuple(int(val) for val in rowcol(...)). Even with a float-returning operation, index() returns integers. Separate its annotation from rowcol’s.
Contributor
Author
There was a problem hiding this comment.
Fixed. TransformMethodsMixin.index() now keeps its integer return type and accepts callbacks returning ConvertibleToInt; only the rowcol() APIs propagate the callback return type. I also added regression assertions covering a float-returning callback for both paths and reran the targeted mypy, Pyright, stubtest, and multi-version checks.
ryux1
force-pushed
the
ryux1/rasterio-rowcol-op-return
branch
from
September 6, 2026 04:27
364da14 to
afdb012
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16342.
Preserve the default integer result while propagating a custom operation's return type through
rowcolandindex.Agent used: OpenAI Codex.