{{ message }}
[docutils] Improve types in docutils.io - #16260
Open
ekanshul wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Are the mypy-primer hits in Sphinx expected?
Member
There was a problem hiding this comment.
Shouldn't this be SupportsWrite[str] | SupportsWrite[bytes] | Literal[False] to mirror the constructor parameter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several attributes and parameters of the
docutils.ioinput/output classes wereIncompleteor unannotated although docutils annotates them inline. This types theencoding,error_handler,destination_pathandautocloseattributes ofOutput/FileOutput, theErrorOutputattributes, the path/encoding/mode parameters of theFileInputandFileOutputconstructors, and theread()/write()methods ofStringInput,StringOutputandFileOutput, following the annotations in docutils 0.23.Agent used: Claude Code