{{ message }}
Upgrade Makefile, it can build single html now#643
Merged
josix merged 5 commits intopython:3.12from Apr 13, 2024
Merged
Conversation
We still need to make all once, and then we can build single html.
b5b35e5 to
2b1bdc6
Compare
mattwang44
reviewed
Sep 5, 2023
Remove redundant 'exit 1'
Collaborator
Contributor
Author
看起來好像不錯,我來改改看 |
- Get argument as build target. - Check extension. - Prevent throwing error when no rule to make target.
Contributor
Author
|
已經採用 @josix 的方法並 push。 A: 目前是 A 方案 |
Collaborator
Contributor
Author
|
@mattwang44 你的意思是想要不管輸入 A 或 B 都可以嗎? 那我這樣子做你覺得如何 (重點是第 2 點):
|
Collaborator
|
我覺得可以,但想請你也一併考慮未來開發彈性:
|
josix
requested changes
Sep 18, 2023
josix
reviewed
Sep 18, 2023
Contributor
Author
There was a problem hiding this comment.
Somebody say this might be harmful since the variable is global, maybe I should use some special prefix on the variable name?
Collaborator
There was a problem hiding this comment.
yeah, how about naming this with underscore prefix
josix
requested changes
Sep 23, 2023
josix
requested changes
Sep 23, 2023
josix
approved these changes
Apr 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


更新
Makefile讓他可以只轉換單一 html 檔。指令為:
VERSION=3.12 make build/<path-to-file>例如:
VERSION=3.12 make build/library/internet,就是要 buildlibrary/internet.po的檔案目前的版本需要大家至少有 make all 一次,之後才能夠使用
make build/<path-to-file>來轉換單一 html 檔。如果 clone 後沒有 make all 過,會失敗;這個問題暫時還找不到解法,附上遇到的錯誤訊息如下:
需要討論:
現在暫時的語法為
make build/<path-to-file>,會看起來很像是要 makebuild/路徑下的檔案需要大家集思廣益,語法應該要怎麼訂比較好,謝謝。