{{ message }}
add version of Richards that uses super()#271
Merged
carljm merged 3 commits intopython:mainfrom Apr 25, 2023
Merged
Conversation
Member
Author
Member
|
Yep, see #263 for 3.12+greenlet. |
Member
|
Nice I will take a look |
Member
|
Overall looks good, but why not just replace the Richards to use super()? cc @pablogsal |
Member
Author
I think the main reason is because this means Richards timing is no longer comparable to previous timings? (I'm not sure if this is an issue or not; I'm quite happy to just change Richards if that's ok with the maintainers.) |
AlexWaygood
reviewed
Apr 24, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, none of the benchmarks in pyperformance exercise
super()method calls significantly. But real-world modern object-oriented Python code often does (one source: Instagram server codebase uses lots ofsuper()method calls, some in hot paths.)To correct this gap in visibility, this PR adds a copy of the Richards benchmark that is modified to use
super()calls. Existing super-method calls that were done by naming the base class directly (Task.__init__(self, ...)) are modified to usesuper(), and the already-polymorphicTask.fnmethod is modified slightly such that overrides now call up to the base method usingsuper().If we accept that Richards is a roughly reasonable representation of some object-oriented Python code, I think this is a similarly reasonable representation of the real-world use of
super()in such code.Thanks to @pablogsal for this suggestion.