{{ message }}
Fix refs section removal breaking external links on Sphinx build too - #2229
Merged
Merged
Conversation
Member
Author
JelleZijlstra
approved these changes
Jan 12, 2022
Member
|
It worked :) |
Member
|
But the deploy job failed: https://github.com/python/peps/actions/runs/1685665720. Let's just give GH some time to fix things and maybe rerun it later. |
Member
Author
|
Looks like it has been resolved. Could you re-run? |
Member
|
And, the re-run seems to have succeeded! |
Member
|
Thanks for catching this Cam/all -- docutils can be annoyingly fickle sometimes. As a post-mortem, what we should have done initially is made all Deferring the transform is probably the smallest change to fix it though, and we don't rely on any behaviour transforming the footer links, so all good. Thanks again! A |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Followup to #2227 to fix #2155 for the new Sphinx build; I'd previously attempted to reproduce the issue locally on the same PEP and it apparently didn't occur, but I didn't realize I was looking at a stale built file, and it turns out that in fact the same fix is needed. Sorry for the double PR!