{{ message }}
PEP 639: Update the metadata version to 2.3 as 2.2 already exists - #2140
Closed
hroncok wants to merge 1 commit into
Closed
PEP 639: Update the metadata version to 2.3 as 2.2 already exists#2140hroncok wants to merge 1 commit into
hroncok wants to merge 1 commit into
Conversation
JelleZijlstra
approved these changes
Nov 11, 2021
ofek
approved these changes
Nov 12, 2021
CAM-Gerlach
reviewed
Nov 14, 2021
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
Member
There was a problem hiding this comment.
Thanks for getting started on this! Its 100% my fault for not editing my comment (and for not doing it in the first place), but per @pfmoore 's response, that is actually the one part that I was mistaken about, and instead all the references to the metadata version should be removed instead and the PEP reformatted to look like PEP 643. I'll mention that in a review and drop a PR shortly 🤞 doing that instead. But thanks again for getting things moving!
Member
Contributor
|
@CAM-Gerlach I'd open a PR 👍 |
Member
|
Will do, thanks, sounds like that's what Paul suggested on the Discuss thread a while back too. Got stuck with a big GitHub backlog at the moment but will try to finish by later tonight. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.