{{ message }}
[mypyc] Keep generator local state in C locals when possible - #21982
Merged
Merged
Conversation
…-reg2 # Conflicts: # mypyc/irbuild/statement.py # mypyc/test-data/run-generators.test
p-sawicki
approved these changes
Sep 14, 2026
JukkaL
added a commit
that referenced
this pull request
Sep 15, 2026
Fix a regression introduced by #21982. CFG cleanup correctly removes an unreachable exception-handler block, but generated resume cleanup paths still reference its raw CPy_CatchError CallC result. This leaves malformed IR and causes a KeyError during reference count insertion. Keep the saved exception state in a register so it remains available across the generated control flow. Add regression coverage for compiling and running an async with statement with an empty body. I used coding agent assist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially generate IR for generators and coroutines where locals and temporaries are stored in registers. Only spill registers that are live across a yield/await to the generator object. Previously most registers were stored in the generator object as attributes. The new spill is implemented as a new transform. We still use the old spill transform for op results that are not stored in registers.
This makes microbenchmarks where most work happens between awaits significantly faster, as C locals can be used for many operations instead of attributes. This also reduces the size of generator objects, as fewer struct fields are needed.
Remove old spill-related helpers from the IR builder as unnecessary.
I used coding agent assist.