{{ message }}
[mypyc] Fix bytes join on Python 3.13 - #17527
Closed
JukkaL wants to merge 1 commit into
Closed
Conversation
`_PyBytes_Join` is no longer available. Work on mypyc/mypyc#1056.
Collaborator
cdce8p
reviewed
Jul 14, 2024
| if (method == NULL) { | ||
| return NULL; | ||
| } | ||
| PyObject *res = PyObject_VectorcallMethod( |
Collaborator
There was a problem hiding this comment.
This might fail with 3.8. PyObject_VectorcallMethod was provisional there. The leading underscore was removed in 3.9. _PyObject_VectorcallMethod is available as alias in 3.13 for backwards compatibility.
Collaborator
There was a problem hiding this comment.
This is guarded by CPY_3_13_FEATURES so should be fine on that front, right?
Collaborator
There was a problem hiding this comment.
True, missed that. Although now _PyBytes_Join doesn't need to be fixed for 3.13 anymore. See python/cpython#122287
Collaborator
|
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPython 3.13 no longer has
_PyBytes_Joinor_PyObject_CallMethodIdOneArg.Work on mypyc/mypyc#1056.