{{ message }}
Release cycle chart: show suggestion if JavaScript disabled - #997
Merged
Conversation
Mariatta
approved these changes
Dec 5, 2022
ezio-melotti
approved these changes
Dec 6, 2022
ezio-melotti
left a comment
ezio-melotti
left a comment
Member
There was a problem hiding this comment.
This is an improvement compared to what we have now, but have you considered creating a static image from mermaid at build time (if possible)? This will make it easier to share/embed too.
Member
CAM-Gerlach
approved these changes
Dec 6, 2022
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
Member
There was a problem hiding this comment.
LGTM, FWIW—too bad we have to rely on raw, but I guess it isn't so bad for the devguide.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #988.
Visit https://devguide.python.org/versions/.
Before: with JavaScript enabled
Before: with JavaScript disabled
After: with JavaScript disabled
Instead, hide chart code and advise the user to enable JS if they wish to see the chart:
Uses the advice at https://florianbrinkmann.com/en/css-rules-when-javascript-is-disabled-4536/
Demo
https://cpython-devguide--997.org.readthedocs.build/versions/