{{ message }}
Add "how to" for the setter Argument Clinic directive - #1245
Merged
Conversation
hugovk
reviewed
Dec 10, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Contributor
Member
|
(I'm travelling right now, but will do my best to review this tomorrow or Wednesday!) |
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
I left some suggestions.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
AlexWaygood
reviewed
Dec 13, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Thanks! Some minor points:
Comment on lines
-2040
to
-2041
Member
There was a problem hiding this comment.
Not sure this should be deleted; the Python REPL example at the bottom now has no introduction explaining what it's illustrating
Member
Author
There was a problem hiding this comment.
Okay, I will supplement to the above descriptions.
Member
Author
There was a problem hiding this comment.
Hmm.. I think that "Getters" and "setters" are C functions defined in a :c:type:`PyGetSetDef` struct that facilitate :py:class:`property`-like access for a class will be enough for understand Python REPL..
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Dec 13, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Dec 13, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: python/cpython#112922
📚 Documentation preview 📚: https://cpython-devguide--1245.org.readthedocs.build/