Add inline tabs on Increase Test Coverage page for commands on different systems by lancegoyke · Pull Request #1228 · python/devguide · GitHub
Skip to content

Add inline tabs on Increase Test Coverage page for commands on different systems - #1228

Merged
hugovk merged 4 commits into
python:mainfrom
lancegoyke:testing-coverage
Nov 23, 2023
Merged

hugovk merged 4 commits into
python:mainfrom
lancegoyke:testing-coverage

Conversation

@lancegoyke

@lancegoyke lancegoyke commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

This PR should close a single TODO in #1196.


📚 Documentation preview 📚: https://cpython-devguide--1228.org.readthedocs.build/testing/coverage/

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the page has ./python X and make X commands that we tabify to help macOS/Windows users copy and paste the right one.

And let's also add the JS.

Comment thread testing/coverage.rst
Comment thread testing/coverage.rst
@lancegoyke

Copy link
Copy Markdown
Contributor Author

@hugovk

hugovk commented Nov 18, 2023

Copy link
Copy Markdown
Member

Yeah, I saw that "You can now..." line earlier and wasn't sure... I haven't actually used any of the instructions on this page, they might be outdated and need updating at some point, so let's not worry too much about them now and update them later, if needed.

So I suggest we leave those ./python X as is, and only tabify the make X ones?

@lancegoyke

Copy link
Copy Markdown
Contributor Author

So I suggest we leave those ./python X as is, and only tabify the make X ones?

Sounds good 👍

I ended up forking cpython so that I could test building the docs on my Windows machine because it felt like the command might be the same on all OSes. Verdict: the .\ is indeed very important, haha.

@hugovk

hugovk commented Nov 19, 2023

Copy link
Copy Markdown
Member

@hugovk
hugovk merged commit 40d6473 into python:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants