gh-99706: unicodeobject: Fix padding in `PyASCIIObject.state` by davidhewitt · Pull Request #99707 · python/cpython · GitHub
Skip to content

gh-99706: unicodeobject: Fix padding in PyASCIIObject.state - #99707

Merged
methane merged 1 commit into
python:mainfrom
davidhewitt:patch-2
Nov 24, 2022
Merged

methane merged 1 commit into
python:mainfrom
davidhewitt:patch-2

Conversation

@davidhewitt

@davidhewitt davidhewitt commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Increase padding by 1 bit so that total bitfield size is 32 bits, as the fact the fields currently sum to 31 looks potentially unintended to me.

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane added skip news type-bug An unexpected behavior, bug, or error labels Nov 24, 2022
@methane methane changed the title gh-99706: unicodeobject - PyASCIIObject state to 32 bits gh-99706: unicodeobject: Fix padding in PyASCIIObject.state Nov 24, 2022
@methane
methane merged commit b4d54a3 into python:main Nov 24, 2022
@methane

methane commented Nov 24, 2022

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants