[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) by zooba · Pull Request #99493 · python/cpython · GitHub
Skip to content

[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) - #99493

Merged
ambv merged 2 commits into
python:3.9from
zooba:gh-87604-3.9
Nov 21, 2022
Merged

[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373)#99493
ambv merged 2 commits into
python:3.9from
zooba:gh-87604-3.9

Conversation

@zooba

@zooba zooba commented Nov 14, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot mentioned this pull request Nov 14, 2022
Closed
@zooba zooba changed the title gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) [3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) Nov 14, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 14, 2022
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Nov 14, 2022
@zooba

zooba commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@pablogsal

pablogsal commented Nov 16, 2022

Copy link
Copy Markdown
Member

I am +1 backporting this but maybe you want to check with @ambv instead for 3.9 and 3.8?

@pablogsal

pablogsal commented Nov 16, 2022

Copy link
Copy Markdown
Member

I am assuming 3.10 has the fix already no?

@zooba

zooba commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

🤦 Yes, @ambv, what are your thoughts?

It's already in 3.10 in #99492. The backport couldn't be done automatically to 3.9, which is why it's not linked yet

@ambv

ambv commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

I'm +1 to backport to 3.9 and 3.8.

@ambv
ambv merged commit 7b98207 into python:3.9 Nov 21, 2022
@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Sorry @zooba and @ambv, I had trouble checking out the 3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 7b98207aa46bd637d07a7c4a84e998726b74acde 3.8

@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@zooba
zooba deleted the gh-87604-3.9 branch November 21, 2022 19:05
@bedevere-bot

bedevere-bot commented Nov 21, 2022

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ambv ambv

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @pablogsal @ambv @miss-islington @bedevere-bot