{{ message }}
gh-99139: Improve NameError error suggestion for instances#99140
Merged
pablogsal merged 7 commits intopython:mainfrom Nov 6, 2022
Merged
gh-99139: Improve NameError error suggestion for instances#99140pablogsal merged 7 commits intopython:mainfrom
pablogsal merged 7 commits intopython:mainfrom
Conversation
ammaraskar
approved these changes
Nov 5, 2022
Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
isidentical
reviewed
Nov 5, 2022
isidentical
reviewed
Nov 5, 2022
isidentical
approved these changes
Nov 5, 2022
Member
isidentical
left a comment
isidentical
left a comment
There was a problem hiding this comment.
Looks really helpful, thanks a lot @pablogsal!
pablogsal
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
pablogsal
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4925719 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
kumaraditya303
requested changes
Nov 6, 2022
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
| if (!locals) { | ||
| goto error; | ||
| } | ||
| PyObject* self = PyDict_GetItem(locals, &_Py_ID(self)); /* borrowed */ |
Member
There was a problem hiding this comment.
Do not use PyDict_GetItem. It is broken by design.
Member
Author
There was a problem hiding this comment.
What should we use instead for both?
Member
There was a problem hiding this comment.
PyDict_GetItemWithError and PyObject_GetAttr if limited by public API. It is suggested in the documentation. But _PyObject_LookupAttr is more convenient in the latter case.
| goto error; | ||
| } | ||
|
|
||
| if (PyObject_HasAttr(self, name)) { |
Member
There was a problem hiding this comment.
Do not use PyObject_HasAttr. It is broken by design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.