{{ message }}
GH-94597: Deprecate child watcher getters and setters#98215
Merged
gvanrossum merged 8 commits intopython:mainfrom Oct 15, 2022
Merged
GH-94597: Deprecate child watcher getters and setters#98215gvanrossum merged 8 commits intopython:mainfrom
gvanrossum merged 8 commits intopython:mainfrom
Conversation
kumaraditya303
added
topic-asyncio
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Contributor
Author
|
The buildbots failures are unrelated. See #98216 |
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
gvanrossum
reviewed
Oct 15, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I'm not super keen on indenting all that code, otherwise I am fine with this. However, could you also add some deprecation notes to the docs? What's new in 3.12 also ideally should be updated (isn't there already something about watchers there?)
Contributor
Author
I was planning to finish docs afterwards but I added it now. |
graingert
reviewed
Oct 16, 2022
Contributor
There was a problem hiding this comment.
It isn't safe to disable warnings here, this is a process global and you're disabiling it for the whole wait
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 17, 2022
* main: (31 commits) pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345) pythongh-95914: Add What's New item describing PEP 670 changes (python#98315) Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358) pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316) pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333) pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001) pythongh-97669: Create Tools/build/ directory (python#97963) pythongh-95534: Improve gzip reading speed by 10% (python#97664) pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344) pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336) pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929) pythongh-85525: Remove extra row in doc (python#98337) pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457) pythongh-97527: IDLE - fix buggy macosx patch (python#98313) pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319) pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158) pythonGH-94597: Deprecate child watcher getters and setters (python#98215) pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255) Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294) [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.