[3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD by ambv · Pull Request #98037 · python/cpython · GitHub
Skip to content

[3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD - #98037

Merged
ambv merged 1 commit into
python:3.9from
ambv:fix-unsupported-ssl-proto
Oct 7, 2022
Merged

[3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD#98037
ambv merged 1 commit into
python:3.9from
ambv:fix-unsupported-ssl-proto

Conversation

@ambv

@ambv ambv commented Oct 7, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Example buildbot failure we want to avoid:
https://buildbot.python.org/all/#/builders/151/builds/595/steps/5/logs/stdio

Relevant log excerpt:

0:38:34 load avg: 1.32 Re-running test_ssl in verbose mode (matching: test__create_stdlib_context, test_protocol, test_session_stats)
test__create_stdlib_context (test.test_ssl.ContextTests) ... ERROR
test_protocol (test.test_ssl.ContextTests) ... ERROR
test_session_stats (test.test_ssl.ContextTests) ... ERROR
======================================================================
ERROR: test__create_stdlib_context (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_ssl.py", line 1718, in test__create_stdlib_context
    ctx = ssl._create_stdlib_context(ssl.PROTOCOL_TLSv1,
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 776, in _create_unverified_context
    context = SSLContext(protocol)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 484, in __new__
    self = _SSLContext.__new__(cls, protocol)
ValueError: invalid or unsupported protocol version
======================================================================
ERROR: test_protocol (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_ssl.py", line 1144, in test_protocol
    ctx = ssl.SSLContext(proto)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 484, in __new__
    self = _SSLContext.__new__(cls, protocol)
ValueError: invalid or unsupported protocol version
======================================================================
ERROR: test_session_stats (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_ssl.py", line 1527, in test_session_stats
    ctx = ssl.SSLContext(proto)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 484, in __new__
    self = _SSLContext.__new__(cls, protocol)
ValueError: invalid or unsupported protocol version
----------------------------------------------------------------------
Ran 3 tests in 0.043s
FAILED (errors=3)
test test_ssl failed

@ambv
ambv requested a review from tiran as a code owner October 7, 2022 17:30
@ambv ambv changed the title gh-94208: Add even more TLS version/protocol checks for FreeBSD [3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD Oct 7, 2022
@ambv ambv added the skip news label Oct 7, 2022
@ambv
ambv merged commit da1fe38 into python:3.9 Oct 7, 2022
@ambv
ambv deleted the fix-unsupported-ssl-proto branch October 7, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ambv @bedevere-bot