gh-93738: Disallow pre-v3 syntax in the C domain by AA-Turner · Pull Request #97962 · python/cpython · GitHub
Skip to content

gh-93738: Disallow pre-v3 syntax in the C domain - #97962

Merged
ambv merged 4 commits into
python:mainfrom
AA-Turner:sphinx-3-disallow-pre-v3
Oct 6, 2022
Merged

gh-93738: Disallow pre-v3 syntax in the C domain#97962
ambv merged 4 commits into
python:mainfrom
AA-Turner:sphinx-3-disallow-pre-v3

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Oct 6, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The final part of #93738. This PR disallows pre-v3 syntax in the C domain.

A

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 6, 2022
@AA-Turner

AA-Turner commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

@AA-Turner

AA-Turner commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Sample failing run: https://github.com/python/cpython/actions/runs/3197620393/jobs/5221077105

@AA-Turner AA-Turner mentioned this pull request Oct 6, 2022
Closed
@AA-Turner AA-Turner self-assigned this Oct 6, 2022
@ambv
ambv merged commit f612565 into python:main Oct 6, 2022
@miss-islington

miss-islington commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f612565bd32d4ab0945798da775eea070f08b6fe 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2022
@AA-Turner @miss-islington
pythongh-93738: Disallow pre-v3 syntax in the C domain (pythonGH-97962)
a115680 
Also, disable using invalid sphinx-lint 0.6.2.
(cherry picked from commit f612565)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington miss-islington assigned ambv and unassigned AA-Turner Oct 6, 2022
@bedevere-bot

bedevere-bot commented Oct 6, 2022

Copy link
Copy Markdown

GH-97976 is a backport of this pull request to the 3.11 branch.

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 6, 2022
@AA-Turner @ambv
[3.10] pythongh-93738: Disallow pre-v3 syntax in the C domain (python…
e45b609 
…GH-97962)

Also, disable using invalid sphinx-lint 0.6.2.
(cherry picked from commit f612565)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 6, 2022
@bedevere-bot

bedevere-bot commented Oct 6, 2022

Copy link
Copy Markdown

GH-97977 is a backport of this pull request to the 3.10 branch.

@AA-Turner
AA-Turner deleted the sphinx-3-disallow-pre-v3 branch October 6, 2022 17:20
@arhadthedev arhadthedev mentioned this pull request Oct 6, 2022
Merged
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
7938d6f 
* main:
  pythonGH-88050: fix race in closing subprocess pipe in asyncio  (python#97951)
  pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)
  pythongh-95986: Fix the example using match keyword (python#95989)
  pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)
  pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)
  pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)
  pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)
  pythonGH-88968: Add notes about socket ownership transfers (python#97936)
  pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
@arhadthedev arhadthedev mentioned this pull request Oct 6, 2022
Merged
ambv added a commit that referenced this pull request Oct 6, 2022
@miss-islington @AA-Turner @ambv
[3.11] gh-93738: Disallow pre-v3 syntax in the C domain (GH-97962) (#…
27a7fe3 
…97976)

Also, disable using invalid sphinx-lint 0.6.2.
(cherry picked from commit f612565)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 6, 2022
Closed
ambv added a commit that referenced this pull request Oct 6, 2022
@ambv @AA-Turner
[3.10] gh-93738: Disallow pre-v3 syntax in the C domain (GH-97962) (#…
537c93e 
…97977)

Also, disable using invalid sphinx-lint 0.6.2.
(cherry picked from commit f612565)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovk

hugovk commented Oct 6, 2022

Copy link
Copy Markdown
Member

@hugovk hugovk mentioned this pull request Oct 6, 2022
Merged
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
1af2a98 
* main: (53 commits)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
  pythonGH-88050: fix race in closing subprocess pipe in asyncio  (python#97951)
  pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)
  pythongh-95986: Fix the example using match keyword (python#95989)
  pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)
  pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)
  pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)
  pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)
  pythonGH-88968: Add notes about socket ownership transfers (python#97936)
  pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@AA-Turner @mpage
pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)
32cc2fd 
Also, disable using invalid sphinx-lint 0.6.2.
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @AA-Turner
@ambv @pablogsal
[3.11] gh-93738: Disallow pre-v3 syntax in the C domain (GH-97962) (#…
bf1de26 
…97976)

Also, disable using invalid sphinx-lint 0.6.2.
(cherry picked from commit f612565)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ambv ambv

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner @miss-islington @bedevere-bot @hugovk @ambv