GH-46412: More efficient bool() for ndbm/_gdbmmodule by gvanrossum · Pull Request #96692 · python/cpython · GitHub
Skip to content

GH-46412: More efficient bool() for ndbm/_gdbmmodule - #96692

Merged
gvanrossum merged 3 commits into
python:mainfrom
gvanrossum:faster-dbm-bool
Sep 9, 2022
Merged

gvanrossum merged 3 commits into
python:mainfrom
gvanrossum:faster-dbm-bool

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Sep 8, 2022

Copy link
Copy Markdown
Member

Based on patches uploaded to BPO by BPO user eolson (Eric Olson).
No known email or GitHub username for attribution.

(The bug was opened in 2008, not quite a record but still impressive.)

Based on patches uploaded to BPO by BPO user eolson (Eric Olson).
No known email or GitHub username for attribution.

(The bug was opened in 2008, not quite a record but still impressive.)
@gvanrossum
gvanrossum marked this pull request as ready for review September 8, 2022 20:13

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
LGTM

@gvanrossum

Copy link
Copy Markdown
Member Author

@gvanrossum
gvanrossum merged commit df50938 into python:main Sep 9, 2022
@gvanrossum
gvanrossum deleted the faster-dbm-bool branch September 9, 2022 02:32
@corona10

corona10 commented Sep 9, 2022

Copy link
Copy Markdown
Member

There was a subtle indentation error that caused 'make patchcheck' to fail.

Ooops, I didn't notice that.

@gvanrossum

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants