{{ message }}
GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase - #94593
Merged
Conversation
graingert
requested changes
Jul 6, 2022
kumaraditya303
force-pushed
the
asyncio-ev
branch
from
July 6, 2022 06:19
f59b6eb to
bd1eeb9
Compare
graingert
reviewed
Jul 6, 2022
kumaraditya303
force-pushed
the
asyncio-ev
branch
from
July 6, 2022 06:35
bd1eeb9 to
9576a91
Compare
graingert
reviewed
Jul 6, 2022
graingert
reviewed
Jul 6, 2022
graingert
reviewed
Jul 6, 2022
Contributor
Contributor
Author
I added a test. |
asvetlov
approved these changes
Jul 6, 2022
asvetlov
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
Contributor
Author
Thanks for the reviews! |
Contributor
|
I think the docs should describe this change: |
Contributor
Author
This would complicate things for an average user about how policy registry works. The existing docs is clear |
Contributor
|
Thanks @kumaraditya303 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2022
…ncioTestCase (pythonGH-94593) (cherry picked from commit 14fea6b) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.